RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support [v2]

Kim Barrett kbarrett at openjdk.org
Wed Oct 16 07:54:48 UTC 2024


On Wed, 16 Oct 2024 06:47:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve conditionalization
>
> src/hotspot/share/memory/virtualspace.cpp line 645:
> 
>> 643:   if (UseCompressedOops) {
>> 644:     NOT_LP64(ShouldNotReachHere();)
>> 645: #ifdef _LP64
> 
> `#ifndef ... else ...` would look marginally better IMO.

Yeah, you're right.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21484#discussion_r1802545063


More information about the hotspot-runtime-dev mailing list