Integrated: 8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen

[Gerard Ziemski]

On Tue, 27 Aug 2024 20:42:48 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> We add a small feature, which prints a warning if user explicitly requests `CreateCoredumpOnCrash`, but it's disabled on the os level.
> 
> This behavior is the same as other VM features that can be turned on by runtime flags, but are unavailable. For example we show `"UseCRC32 specified, but not supported on this CPU"` if `UseCRC32` is set, but unavailable.
> 
> Example of output:
> 
> 
> # ulimit -c 0                                                         
> # ./build/xcode/build/jdk/bin/java -XX:+CreateCoredumpOnCrash -version
> OpenJDK 64-Bit Server VM warning: CreateCoredumpOnCrash specified, but Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
> openjdk version "24-internal" 2025-03-18
> OpenJDK Runtime Environment (build 24-internal-adhoc.gerard.jdk)
> OpenJDK 64-Bit Server VM (build 24-internal-adhoc.gerard.jdk, mixed mode, sharing)
> 
> # ulimit -c 1024                                                      
> # ./build/xcode/build/jdk/bin/java -XX:+CreateCoredumpOnCrash -version
> OpenJDK 64-Bit Server VM warning: CreateCoredumpOnCrash specified, but /cores/core.66547 (max size 512 k). To ensure a full core dump, try "ulimit -c unlimited" before starting Java again
> openjdk version "24-internal" 2025-03-18
> OpenJDK Runtime Environment (build 24-internal-adhoc.gerard.jdk)
> OpenJDK 64-Bit Server VM (build 24-internal-adhoc.gerard.jdk, mixed mode, sharing)
> 
> # ulimit -c unlimited
> # ./build/xcode/build/jdk/bin/java -XX:+CreateCoredumpOnCrash -version
> openjdk version "24-internal" 2025-03-18
> OpenJDK Runtime Environment (build 24-internal-adhoc.gerard.jdk)
> OpenJDK 64-Bit Server VM (build 24-internal-adhoc.gerard.jdk, mixed mode, sharing)
> 
> 
> 
> 
> 
> Testing:
> - passes `gtest runtime/ErrorHandling/CreateCoredumpOnCrash.java`
> - passes MACH5 tier1,tier2,tier3,tier4,tier5

This pull request has now been integrated.

Changeset: c34fb2c9
Author:    Gerard Ziemski <gziemski at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c34fb2c989562206a2506a2fbbfb584e223bb828
Stats:     136 lines in 6 files changed: 63 ins; 12 del; 61 mod

8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen

Reviewed-by: dholmes, jsjolen

-------------

PR: https://git.openjdk.org/jdk/pull/20734