RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support [v2]

[Kim Barrett]

On Wed, 16 Oct 2024 07:59:52 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve conditionalization
>
> src/hotspot/share/memory/virtualspace.cpp line 646:
> 
>> 644: #ifndef _LP64
>> 645:     NOT_LP64(ShouldNotReachHere();)
>> 646: #else
> 
> Suggestion:
> 
> #ifndef _LP64
>     ShouldNotReachHere();
> #else
> 
> With that said, I think it would be nicer to invert the code:
> 
> #ifdef _LP64
>   ... All the code we typically care of up front
> #else
>   ... Code we typically ignore
>   ShouldNotReachHere();
> #endif

Yeah, forgot to remove the NOT_LP64.

Flipping the order seemed like it made the 32bit case coverage easy to miss.  But maybe that's okay. 
And it's not really all that far apart.  So okay, I've made that change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21484#discussion_r1803881495