RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support [v3]

David Holmes dholmes at openjdk.org
Thu Oct 17 01:55:16 UTC 2024


On Wed, 16 Oct 2024 22:48:50 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to ReservedHeapSpace to conditionally include the
>> support for compressed oops only in 64bit builds.  This code is unused and
>> inapplicable in 32bit builds.  Further, it contains code that is problematic
>> in a 32bit build.  See the JBS issue for details.
>> 
>> Testing: mach5 tier1, GHA testing
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into conditional-compile-compressed-heap-support
>  - swap cond block
>  - improve conditionalization
>  - disable coops setup for 32bit

LGTM

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21484#pullrequestreview-2373983089


More information about the hotspot-runtime-dev mailing list