RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 [v4]

Robbin Ehn rehn at openjdk.org
Thu Oct 17 13:37:16 UTC 2024


On Fri, 4 Oct 2024 14:50:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Add missing StoreLoad fences in handshaking code to match safepoint code.  Thanks to @pchilano for finding this bug.
>> 
>> Tested with tier1-4 and tier8 which has Kitchensink in it.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Put suspend handshake fence() where Robbin suggested.

If it floats your boat go ahead, thanks!

-------------

Marked as reviewed by rehn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21295#pullrequestreview-2375266797


More information about the hotspot-runtime-dev mailing list