RFR: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test [v2]
Ioi Lam
iklam at openjdk.org
Fri Oct 18 16:55:37 UTC 2024
On Thu, 17 Oct 2024 09:31:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Found a test bug while testing [JDK-8341913](https://bugs.openjdk.org/browse/JDK-8341913) with Shenandoah. For OOM testing, the test fills out the heap with large arrays and then attempts to allocate a smaller array.
>>
>> That allocation almost always succeeds with Shenandoah. Actually, it succeeds with other GCs as well, it just so happens that other GCs throw OOM with "GC overhead limit exceeded".
>>
>> Plus, some allocations should be sinked to avoid dead-code elimination.
>>
>> Additional testing:
>> - [x] Linux x86_64 server fastdebug, test now passes reliably with JDK-8341913 and Shenandoah
>> - [x] Linux x86_64 server fastdebug, test with {Serial, Parallel, G1, Shenandoah}, 50 times
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> More precise code
LGTM. Thank you for the explanation.
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21536#pullrequestreview-2378579471
More information about the hotspot-runtime-dev
mailing list