RFR: 8341913: Support CDS heap dumping for Shenandoah and Epsilon [v2]

Ioi Lam iklam at openjdk.org
Tue Oct 22 16:52:08 UTC 2024


On Tue, 22 Oct 2024 16:01:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/IncompatibleOptions.java line 116:
>> 
>>> 114:         if (GC.Shenandoah.isSupported()) {
>>> 115:             testDump(4, "-XX:+UseShenandoahGC", "", "", false);
>>> 116:         }
>> 
>> I didn't realize that Epsilon is also included in this PR. Should we add a test case for Epsilon as well?
>
> I don't really want to add Epsilon tests, because we are playing with potential OOMs, and that would likely manifest as test bugs in future, once we create _a little bit more_ garbage in tests. So I just tested Epsilon manually. We also do not test Epsilon automatically in Leyden repo for the same reason.

Sounds fair

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21457#discussion_r1811065714


More information about the hotspot-runtime-dev mailing list