RFR: 8340177: Malformed system classes loaded by bootloader crash the JVM in product builds

[Coleen Phillimore]

On Tue, 22 Oct 2024 00:23:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

> For core classes where verification is by default disabled, product builds would check for parsing/verification constraint violations but then ignore them. In contrast a debug build would check and report them even if verification were disabled. To make it easier for developers testing in product mode predominantly we changed the behaviour so that these constraints are always checked and reported. The intent was for product builds to run faster by skipping the checks, but in practice that doesn't happen - see bug report for background details.
> 
> The simple fix is to replace `check_property` calls with `guarantee_property`.
> 
> Testing:
>  - tiers 1-4
>  - basic performance/footprint testing (no significant changes)
> 
> Thanks

This is nice plus a bonus cleanup.  Thanks!

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21626#pullrequestreview-2385863077