Integrated: 8340177: Malformed system classes loaded by bootloader crash the JVM in product builds

David Holmes dholmes at openjdk.org
Wed Oct 23 21:42:11 UTC 2024


On Tue, 22 Oct 2024 00:23:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

> For core classes where verification is by default disabled, product builds would check for parsing/verification constraint violations but then ignore them. In contrast a debug build would check and report them even if verification were disabled. To make it easier for developers testing in product mode predominantly we changed the behaviour so that these constraints are always checked and reported. The intent was for product builds to run faster by skipping the checks, but in practice that doesn't happen - see bug report for background details.
> 
> The simple fix is to replace `check_property` calls with `guarantee_property`.
> 
> Testing:
>  - tiers 1-4
>  - basic performance/footprint testing (no significant changes)
> 
> Thanks

This pull request has now been integrated.

Changeset: 28d23ada
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/28d23ada6dde007ed60b8538cc159afc62d76db3
Stats:     114 lines in 2 files changed: 0 ins; 55 del; 59 mod

8340177: Malformed system classes loaded by bootloader crash the JVM in product builds

Reviewed-by: coleenp, mli

-------------

PR: https://git.openjdk.org/jdk/pull/21626


More information about the hotspot-runtime-dev mailing list