RFR: 8342953: RISC-V: Fix definition of RISCV_HWPROBE_EXT_ZVFHMIN
Robbin Ehn
rehn at openjdk.org
Fri Oct 25 09:19:06 UTC 2024
On Thu, 24 Oct 2024 11:05:20 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Hi,
>
> Please review this trivial change correcting definition of macro `RISCV_HWPROBE_EXT_ZVFHMIN`.
>
> This macro is supposed to be used when making a `hwprobe` linux syscall for detecting the Zvfhmin extension. Current definition yields a negative 32bits value, messing up hwprobe result when Zvfhmin extension presents. Replace it by using a 1ULL bit shift value as done in kernel upstream [1]. Although it is not used by the JVM for now, it's better to fix it for consistency with the kernel upstream.
>
> [1] https://github.com/torvalds/linux/commit/5ea6764d9095e234b024054f75ebbccc4f0eb146
lgtm
-------------
Marked as reviewed by rehn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21680#pullrequestreview-2394708387
More information about the hotspot-runtime-dev
mailing list