RFR: 8342607: Enhance register printing on x86_64 platforms [v5]

Martin Doerr mdoerr at openjdk.org
Fri Oct 25 17:21:21 UTC 2024


On Fri, 25 Oct 2024 16:00:06 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check should use >=.
>
> src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp line 547:
> 
>> 545:   st->cr();
>> 546:   st->print("  TRAPNO=" INTPTR_FORMAT, (intptr_t)uc->uc_mcontext.gregs[REG_TRAPNO]);
>> 547: #ifndef MUSL_LIBC
> 
> Isn't it compiling on MUSL? `ucontext_t` and `mcontext_t` seem to be equal looking at https://git.musl-libc.org/cgit/musl/tree/arch/x86_64/bits/signal.h
> Also the context comes from the kernel and should have the same layout I thought.
> If it isn't working then I guess the changes in debug.cpp won't work for MUSL either ;)

Let's give it a try. See Commit nr. 6.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21615#discussion_r1817079374


More information about the hotspot-runtime-dev mailing list