RFR: 8288298: Resolve multiline message parsing ambiguities in UL

Johan Sjölen jsjolen at openjdk.org
Tue Oct 29 09:23:15 UTC 2024


On Mon, 28 Oct 2024 08:18:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> We already know the length of the string, so why use something that needs to find the length again?
>> 
>> We shouldn't need the `ALLOW_C_FUNCTION` for memcpy however, the rest of the codebase doesn't use it. Raw malloc here is the good choice, as to avoid circular logging.
>
> Good point. I was thinking more why break a strdup into the composite alloc + memcpy. And do we really want to avoid NMT here?

I'm worried about NMT using UL to log a message and reaching this piece of code again, that's an infinite loop :-).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21712#discussion_r1820412874


More information about the hotspot-runtime-dev mailing list