RFR: 8288298: Resolve multiline message parsing ambiguities in UL [v2]

[Antón Seoane]

On Mon, 28 Oct 2024 05:58:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Antón Seoane has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Removed traling whitespace
>>  - Review comments
>
> src/hotspot/share/logging/logFileStreamOutput.cpp line 119:
> 
>> 117: }
>> 118: 
>> 119: int LogFileStreamOutput::write_internal_line(const LogDecorations& decorations, const char* msg, int msg_len) {
> 
> Suggestion:
> 
> int LogFileStreamOutput::write_internal_lines(const LogDecorations& decorations, const char* msg, int msg_len) {
> 
> Not sure we can't just fold this altogether in `write_internal`.

I guess we can, but I liked the idea of separating the logic for each "step". In any case, I changed the function name as per your suggestion as it made it to look like it just printed one line

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21712#discussion_r1822684986