RFR: 8343321: Bad verify in LockStack::oops_do()

[Joel Sikström]

Hello,

Verifying the lock stack's consistency before calling do_oop on the content in the lock stack is unnecessary and may result in a crash. The call to do_oop will (potentially) only change oops already stored in the lock stack, not add or remove anything. If two (or more) oops were equal before doing do_oop on all oops, they will still be the equivalent after the operation. Hence, the consistensy check only needs to happen once, either before or after do_oops, and doing it before might crash, so I propose we remove it.

See exact crash details in the linked issue.

-------------

Commit messages:
 - 8343321: Bad verify in LockStack::oops_do()

Changes: https://git.openjdk.org/jdk/pull/21806/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21806&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343321
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21806.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21806/head:pull/21806

PR: https://git.openjdk.org/jdk/pull/21806