RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v3]

Martin Doerr mdoerr at openjdk.org
Thu Oct 31 17:29:30 UTC 2024


On Thu, 31 Oct 2024 16:43:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> the bsd zero code had previously this
> 
> ```
> void os::print_tos_pc(outputStream *st, const void *context) {
>   ShouldNotCallThis();
> }
> ```
> 
> Is the new common / unified coding now working there? Or is it not called anyway ?

It's not called. And the new implementation calls `fetch_frame_from_context` which also contains `ShouldNotCallThis();`. So, it's basically no change for zero.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21809#issuecomment-2450435275


More information about the hotspot-runtime-dev mailing list