RFR: 8338136: Hotspot should support multiple large page sizes on Windows
David Holmes
dholmes at openjdk.org
Tue Sep 3 04:25:18 UTC 2024
On Tue, 3 Sep 2024 00:34:39 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:
>> Hi @dhanalla ,
>>
>> What criteria do you think would suffice for `EnableAllLargePageSizesForWindows` to default to true or else be removed altogether, in the future?
>
>> Hi @dhanalla ,
>>
>> What criteria do you think would suffice for `EnableAllLargePageSizesForWindows` to default to true or else be removed altogether, in the future?
>
> Thanks @dholmes-ora for reviewing this PR.
>
> To determine the best time to set `EnableAllLargePageSizesForWindows` to true by default or consider its removal, we first need to gather customer feedback. Once we have confirmed its effectiveness, we can assess the option of making it the default setting. At that stage, the `-XX:+UseLargePages` flag should adequately manage all large page scenarios.
@dhanalla do you think your customers will be okay running with an experimental flag enabled?
The changes seem fine. I'm running them through our CI with the flag disabled and enabled to see if anything interesting happens.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20758#issuecomment-2325576844
More information about the hotspot-runtime-dev
mailing list