RFR: 8339575: DumpingWithJavaAgent.java failed with missing expected output

[David Holmes]

On Thu, 5 Sep 2024 19:36:37 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> [JDK-8338530](https://bugs.openjdk.org/browse/JDK-8338530) altered DumpingwithJavaAgent to include a check for a new output, however this test can be run with dynamic dumping enabled which leads to the expected output not being generated. This patch moves the test case to a more reasonable location which only checks for static dumping. Verified with tier 1-5 tests.

Seems reasonable. One alignment nit.

Thanks

test/hotspot/jtreg/runtime/cds/appcds/StaticArchiveWithLambda.java line 56:

> 54:             .setArchiveName(archiveName);
> 55:         CDSTestUtils.createArchiveAndCheck(opts)
> 56:             .shouldContain("Skipping java/lang/invoke/BoundMethodHandle$Species_LLLL because it is dynamically generated");

Suggestion:

        CDSTestUtils.createArchiveAndCheck(opts)
                    .shouldContain("Skipping java/lang/invoke/BoundMethodHandle$Species_LLLL because it is dynamically generated");

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20875#pullrequestreview-2285042192
PR Review Comment: https://git.openjdk.org/jdk/pull/20875#discussion_r1746585716