RFR: 8339488: Extended NPE message doesn't handle CONSTANT_Dynamic [v2]

[Oli Gillespie]

On Fri, 6 Sep 2024 14:43:16 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused import
>
> test/hotspot/jtreg/runtime/condy/CondyExtendedNullPointerTest.java line 28:
> 
>> 26:  * @bug 8339488
>> 27:  * @summary Test extended NullPointerException message in method with CONSTANT_Dynamic.
>> 28:  * @requires vm.flagless
> 
> Is there are any reasons to ignore all additional vm flags? Usually the test should accept any flags and be flagless only if there are known reasons for this. Even if it doesn't looks to be useful to run in different modes. Usually to stress comiplers with different bycodes.
> You don't need to run test in an additional configurations.

I copied from CondyLDCTest - I figured the authors must have thought about something I didn't.

> test/hotspot/jtreg/runtime/condy/CondyExtendedNullPointerTest.java line 37:
> 
>> 35: import jdk.test.lib.process.ProcessTools;
>> 36: import jdk.test.lib.process.OutputAnalyzer;
>> 37: import jdk.test.lib.compiler.InMemoryJavaCompiler;
> 
> Seems InMemoryJavaCompiler  is not used anymore.

True. I just copied from CondyLDCTest which I guess also has it unused. Will remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20889#discussion_r1747257897
PR Review Comment: https://git.openjdk.org/jdk/pull/20889#discussion_r1747257929