RFR: 8338136: Hotspot should support multiple large page sizes on Windows
Dhamoder Nalla
dhanalla at openjdk.org
Fri Sep 6 18:33:10 UTC 2024
On Tue, 3 Sep 2024 17:16:45 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:
>> The interesting tests were skipped:
>>
>> Skipping test because lock memory privilege is not granted
>>
>> what do you need to make the "lock memory privilege" available?
>>
>> EDIT: never mind I found it.
>
>> The interesting tests were skipped:
>>
>> ```
>> Skipping test because lock memory privilege is not granted
>> ```
>>
>> what do you need to make the "lock memory privilege" available?
>>
>> EDIT: never mind I found it.
>
> Thanks for running through CI.
> If you're still looking for the option, here's the path in gpedit.msc to configure the "Lock pages in memory" setting. To add a user or user group:
> Computer Configuration > Windows Settings > Security Settings > Local Policies > User Rights Assignment > "Lock pages in memory"
> @dhanalla do you think your customers will be okay running with an experimental flag enabled?
>
> The changes seem fine. I'm running them through our CI with the flag disabled and enabled to see if anything interesting happens.
@dholmes-ora, Could you please advise if we can remove the 'experimental' designation for EnableAllLargePageSizesForWindows and keep it set to false by default for now, with the possibility of changing it to true by default or removing it at a later date?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20758#issuecomment-2334607513
More information about the hotspot-runtime-dev
mailing list