RFR: 8335167: Test runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v2]

[Afshin Zafari]

On Mon, 9 Sep 2024 07:44:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I can't discern what the core changes are here such that the now passes more reliably. Why did you change from distinct @test cases to running the test in each mode within a single @test? The refactoring makes it very difficult to see what has actually changed and you haven't described it.
> 
> Also what testing did you do for this? What was the old failure rate?
> 
> Thanks

I have updated the PR description with more details to make the change more clear.
This single test has run on all main platforms in repeated (100+) times on mach5.

> test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java line 99:
> 
>> 97:       ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(vmArgs);
>> 98:       OutputAnalyzer output = new OutputAnalyzer(pb.start());
>> 99:       output.reportDiagnosticSummary();
> 
> Pre-existing, but this should go at the end, otherwise if a test fails you will get two summaries printed.

`reportDiagnosticSummary` should be called to get the outputs to stdout and then look for some specific patterns inside the stdout of the `OutputAnalyzer` object. The call is not for showing the error case of the tests. The calls to `shouldContain` , `shouldNotContain` and more, check the expected pattern to be present in the output.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20531#issuecomment-2337564908
PR Review Comment: https://git.openjdk.org/jdk/pull/20531#discussion_r1749887048