RFR: 8338912: CDS: Segmented roots array [v4]

[Aleksey Shipilev]

On Fri, 6 Sep 2024 17:38:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Helper methods introduced, the code should look cleaner now.
>> 
>>> I think you can remove the special relocation code in ArchiveHeapWriter::relocate_embedded_oops by storing the requested address of val into segment_oop.
>> 
>> Comprehension check: this effectively does the relocation right away, right? I can try, but I prefer not to do more than neccessary for segmented root arrays to work :)
>
> Actually my suggestion won't work, because the creation of the root segments are now down before the root objects are copied, so we don't know their requested address yet.

OK, I will not pursue it then. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20858#discussion_r1750083730