RFR: 8338912: CDS: Segmented roots array [v4]
Aleksey Shipilev
shade at openjdk.org
Mon Sep 9 11:31:13 UTC 2024
On Fri, 6 Sep 2024 17:59:47 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Amend printout as well
>
> src/hotspot/share/cds/heapShared.cpp line 775:
>
>> 773:
>> 774: void HeapShared::add_root_segment(oop segment_oop) {
>> 775: if (segment_oop != nullptr) {
>
> null check is not necessary. Also parameter type should be objArray.
Should be done in new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20858#discussion_r1750083323
More information about the hotspot-runtime-dev
mailing list