RFR: 8338883: Add core dump info to -Xlog:os=info [v2]

[Gerard Ziemski]

On Thu, 29 Aug 2024 01:00:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

> BTW see the 2015 code review thread for more info on current functions and naming, in particular Thomas's summary here: https://mail.openjdk.org/pipermail/hotspot-runtime-dev/2015-March/014356.html

Thank you for the pointer, I used the name Thomas has suggested  - `check_core_prerequisites()`.

> src/hotspot/os/posix/os_posix.cpp line 147:
> 
>> 145:   }
>> 146: 
>> 147:   VMError::record_coredump_status(buffer, success);
> 
> It may cause confusion to set this when the logging query is being run. Ideally this would only be done for the actual dumping case. If you pass a parameter to indicate whether the call is for an actual dump then you can skip this in the logging case, and also fold back `prepare_for_dump` back into to this method.

Fixed.

> src/hotspot/share/runtime/os.hpp line 937:
> 
>> 935: 
>> 936:   // On Posix compatible OS it will simply check core dump limits while on Windows
>> 937:   // it will check for a client versions of Windows. Use the caller
> 
> s/versions/version/

Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20734#issuecomment-2338928606
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1750646545
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1750646182