RFR: 8338626: CDS handling of JAR Class-Path attribute should allow / separator on Windows

Calvin Cheung ccheung at openjdk.org
Mon Sep 9 22:12:05 UTC 2024


On Mon, 9 Sep 2024 21:48:34 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> On Windows, we can use '/' as the file separator in the classpath but not in the `Class-Path:` attribute.
>> This patch is to enable the use of '/' as the file separator in the `Class-Path:`attribute on Windows.
>> 
>> Passed tiers 1 - 3 testing.
>
> test/hotspot/jtreg/runtime/cds/appcds/ClassPathAttr.java line 88:
> 
>> 86: 
>> 87:       // Test handling of forward slash ('/') file separator for Class-Path attribute on Windows.
>> 88:       if (Platform.isWindows()) {
> 
> Does the new test work for other platforms as well? If so, I think we should remove this check.

It does. Since other platforms have '/' as the file separator, running it again would be wasting of time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1750998171


More information about the hotspot-runtime-dev mailing list