RFR: 8338626: CDS handling of JAR Class-Path attribute should allow / separator on Windows

Ioi Lam iklam at openjdk.org
Mon Sep 9 23:25:06 UTC 2024


On Mon, 9 Sep 2024 22:09:07 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/cds/appcds/ClassPathAttr.java line 88:
>> 
>>> 86: 
>>> 87:       // Test handling of forward slash ('/') file separator for Class-Path attribute on Windows.
>>> 88:       if (Platform.isWindows()) {
>> 
>> Does the new test work for other platforms as well? If so, I think we should remove this check.
>
> It does. Since other platforms have '/' as the file separator, running it again would be wasting of time.

That makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1751048666


More information about the hotspot-runtime-dev mailing list