RFR: 8338883: Add core dump info to -Xlog:os=info [v4]

[Gerard Ziemski]

On Tue, 10 Sep 2024 07:56:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix bufferSize name
>
> src/hotspot/os/posix/os_posix.cpp line 143:
> 
>> 141:   }
>> 142: 
>> 143:   VMError::record_coredump_status(buffer, status);
> 
> I think this was meant to be conditional:
> Suggestion:
> 
> if (!check_only) {
>   VMError::record_coredump_status(buffer, status);
> }

Fixed.

> src/hotspot/os/windows/os_windows.cpp line 1321:
> 
>> 1319:   }
>> 1320: 
>> 1321:   VMError::record_coredump_status(buffer, status);
> 
> Again I think this was intended to be conditional on `check_only`.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1752722728
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1752722626