RFR: 8306679: com/sun/jdi/InterruptHangTest.java asserts with -Xcomp -Dmain.wrapper=Virtual options

Leonid Mesnik lmesnik at openjdk.org
Wed Sep 11 03:19:04 UTC 2024


On Wed, 11 Sep 2024 02:57:33 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The test is failing with virtual threads because the `cur_stack_depth()` of a virtual thread executed in `interp_only` mode is invalidated conditionally in the `ThawBase::thaw_slow()`:
> ```JVMTI_ONLY(if (!return_barrier) invalidate_jvmti_stack(_thread));```
> 
> It has to be invalidated unconditionally instead:
> ```JVMTI_ONLY(invalidate_jvmti_stack(_thread));```
> 
> Testing:
>  - ran the test `com/sun/jdi/InterruptHangTest.java` locally and with mach5
>  - the mach5 tiers 1-6 all passed

The changes looks good, however the test might still failing because of 8043571.
Let see in CI if 8043571 is still reproducible and close bug 8043571 if not.

-------------

Marked as reviewed by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20943#pullrequestreview-2295193329


More information about the hotspot-runtime-dev mailing list