RFR: 8338626: CDS handling of JAR Class-Path attribute should allow / separator on Windows

Calvin Cheung ccheung at openjdk.org
Wed Sep 11 04:24:07 UTC 2024


On Wed, 11 Sep 2024 01:30:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> To me it sounds like the logic should be always using `/` to locate and then use file_seperator to rewrite to a classpath filesystem entry.
>
> No strike that, the logic is more complex.
> 
>> Before the patch, on Windows, it only works with '\' (the default file separator). e.g. java -cp dir1\A.jar ... .
> 
> So you want to be able to process the classpath if it uses `/` instead of `` on Windows? Is that how classpath processing normally works on Windows?
> 
> The JBS issue says it is fixing the processing of the Class-path attribute, not the processing of the classpath entries. Or maybe I have just misconstrued exactly what this is fixing - the Class-path attribute itself is immaterial here??

To better describe what we're fixing, how about changing the JBS title to the following?
`CDS: allow the use of / separator on Windows to locate entries from the Class-Path attribute`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1753097914


More information about the hotspot-runtime-dev mailing list