RFR: 8339159: api/java_rmi/Naming/Rebind.html crashes with SEGV from UTF8::quoted_ascii_length call [v2]

[David Holmes]

On Wed, 11 Sep 2024 06:57:22 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplified approach based on @iklam's suggestion
>
> src/hotspot/share/classfile/symbolTable.cpp line 178:
> 
>> 176:       if (!SymbolTable::arena()->Afree(memory, alloc_size)) {
>> 177:         // Can't print the now free'd symbol's value, but we just printed it above.
>> 178:         NOT_PRODUCT(log_trace(symboltable)(" - Leaked permanent symbol");)
> 
> I think the comment may cause more confusion than its worth (the symbol hasn't been  "freed", or else there wouldn't be a leak). It's better to remove the comment.

I modified the comment but still want it to ensure someone is not tempted to revert to the `log_trace_symboltable_helper` call - as it looks odd to use two different logging mechanisms so close together.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20865#discussion_r1755618785