RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v2]

Calvin Cheung ccheung at openjdk.org
Thu Sep 12 00:15:22 UTC 2024


On Wed, 11 Sep 2024 07:36:48 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comment
>
> src/hotspot/share/classfile/classLoaderExt.cpp line 219:
> 
>> 217:     // On Windows, we also support forward slash as the file separator for Class-Path: attribute.
>> 218:     if (dir_tail == nullptr) {
>> 219:       dir_tail = strrchr(dir_name, '/');
> 
> There's still a bug in the current patch. If the input is
> 
> 
> java -cp a\b/c.jar
> 
> 
> The current patch gets "a" as the directory name, but it should get "a\b" instead.

I've pushed an updated fix to address this above. Also added a test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1755886487


More information about the hotspot-runtime-dev mailing list