RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v2]
Calvin Cheung
ccheung at openjdk.org
Thu Sep 12 04:25:39 UTC 2024
On Thu, 12 Sep 2024 00:38:44 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @iklam comment
>
> src/hotspot/share/classfile/classLoaderExt.cpp line 217:
>
>> 215: const char* dir_tail = strrchr(dir_name, sep);
>> 216: #ifdef _WINDOWS
>> 217: // On Windows, we also support forward slash as the file separator when locating entries in the Class-Path: attribute.
>
> Suggestion:
>
> // On Windows, we also support forward slash as the file separator when locating entries in the classpath entry.
>
> The forward slash is not being used in relation to any Class-path attribute here.
Updated the comment.
Also updated the test so it can be run more reliably.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1756089045
More information about the hotspot-runtime-dev
mailing list