RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v3]

David Holmes dholmes at openjdk.org
Thu Sep 12 06:14:17 UTC 2024


On Thu, 12 Sep 2024 04:25:39 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> On Windows, we can use '/' as the file separator in the classpath but not in the `Class-Path:` attribute.
>> This patch is to enable the use of '/' as the file separator in the `Class-Path:`attribute on Windows.
>> 
>> Passed tiers 1 - 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @dholmes-ora comment and test update

test/hotspot/jtreg/runtime/cds/appcds/ClassPathAttr.java line 87:

> 85:           });
> 86: 
> 87:       // Test handling of forward slash ('/') file separator for Class-Path attribute on Windows.

Again this comment is wrong/misleading - the / is in the classpath entry

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1756189398


More information about the hotspot-runtime-dev mailing list