RFR: 8335167: Test runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v4]

[Afshin Zafari]

On Fri, 13 Sep 2024 01:55:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the place of calling reportDiagnosticSummary
>
> test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java line 99:
> 
>> 97:       ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(vmArgs);
>> 98:       OutputAnalyzer output = new OutputAnalyzer(pb.start());
>> 99: 
> 
> IIUC by moving this into the exception throwing paths, it means that if `main` detects a failure and throws, there will not be any output reported. All you needed to do with this was move it after line 118:
> 
>    output.shouldMatch("- *Thread.*reserved.*committed");

Sorry for the misunderstanding and thank you for the precise correction.
Now it is done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20531#discussion_r1758433901