RFR: 8338912: CDS: Segmented roots array [v8]

[Aleksey Shipilev]

On Thu, 12 Sep 2024 22:54:17 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make sure HeapRootSegments representation does not hold garbage
>
> src/hotspot/share/cds/filemap.cpp line 293:
> 
>> 291:   st->print_cr("- mapped_base_address:            " INTPTR_FORMAT, p2i(_mapped_base_address));
>> 292:   st->print_cr("- heap_root_segments.roots_count: %d" , _heap_root_segments.roots_count());
>> 293:   st->print_cr("- heap_root_segments.base_offset: " SIZE_FORMAT, _heap_root_segments.base_offset());
> 
> Existing offset value are being printed with the format SIZE_FORMAT_X. Maybe use the same format here.

Right, this should remain in hex. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20858#discussion_r1758445622