RFR: 8306679: com/sun/jdi/InterruptHangTest.java asserts with -Xcomp -Dmain.wrapper=Virtual options [v2]

Leonid Mesnik lmesnik at openjdk.org
Sat Sep 14 20:35:03 UTC 2024


On Sat, 14 Sep 2024 11:15:37 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The test is failing with virtual threads because the `cur_stack_depth()` of a virtual thread executed in `interp_only` mode is invalidated conditionally in the `ThawBase::thaw_slow()`:
>> ```JVMTI_ONLY(if (!return_barrier) invalidate_jvmti_stack(_thread));```
>> 
>> It has to be invalidated unconditionally instead:
>> ```JVMTI_ONLY(invalidate_jvmti_stack(_thread));```
>> 
>> Testing:
>>  - ran the test `com/sun/jdi/InterruptHangTest.java` locally and with mach5
>>  - the mach5 tiers 1-6 all passed
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   return InterruptHangTest.java to ProblemList-Xcomp.txt under 8043571

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20943#pullrequestreview-2305199993


More information about the hotspot-runtime-dev mailing list