RFR: 8339192: Native annotation parsing code of deprecated annotations causes crash [v2]

David Holmes dholmes at openjdk.org
Tue Sep 17 07:09:05 UTC 2024


On Tue, 17 Sep 2024 06:01:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> jvms specifies the convention of 1 for true and 0 for false. We can technically ignore other values, but in instructions like bastore it takes a bitwise and per jvms.
>
> Also I'm not clear what encoding you are envisaging as the "normal" C based encoding would be zero == false and anything else is true - but that doesn't map to  using `& 1`.

Ah now I see what JVMS is specifying: only look at the LSB to determine true or false.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21030#discussion_r1762509849


More information about the hotspot-runtime-dev mailing list