RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v2]
Matthias Baesken
mbaesken at openjdk.org
Tue Sep 17 07:20:17 UTC 2024
On Mon, 16 Sep 2024 14:16:19 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this trivial test fix. The test fails if the `<slice>.d` directory already exists (for some reason). It needs to exist for the test to work. But if it exists we ignore the failure, thus using `Files.createDirectories()`.
>>
>> As a benefit I've also added `exclusiveAccess.dirs=.` to the `systemd` test directory to match container tests in `docker` folder and added `TRUNCATE_EXISTING` and `CREATE` open options for files in the `<slice>.d` directory. Both of which should ensure the test runs more reliably.
>>
>> Testing:
>> - [ ] GHA
>> - [x] Manual testing by creating the directory first, running the test. Failed. The same handshake passes after the patch.
>>
>> Thanks!
>
> Severin Gehwolf has updated the pull request incrementally with three additional commits since the last revision:
>
> - Cleanup files when systemd --user fails
> - Skip test if systemd user manager not properly working
> - Add CREATE open option.
The test now passes in our latest test run on the 'problematic' machine.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20989#issuecomment-2354734034
More information about the hotspot-runtime-dev
mailing list