RFR: 8298614: Support CDS heap dumping for non-G1 collectors

[Matias Saavedra Silva]

On Mon, 16 Sep 2024 19:26:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This patch upstreams [JDK-8333222](https://bugs.openjdk.org/browse/JDK-8333222) from the Leyden repo to support Serial and Parallel GC for CDS. Additional test fixes not in that patch were added. Verified with tier 1-5 tests.
>
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InvalidFileFormat.java line 29:
> 
>> 27:  * @summary Check most common errors in file format
>> 28:  * @requires vm.cds.write.archived.java.heap
>> 29:  * @requires vm.flagless
> 
> I think the reason you needed to add `vm.flagless` is SharedStringsUtils explicitly adds `-XX:UseG1GC` (long time ago this was required to dump the Java heap objects). It's better to remove `-XX:UseG1GC`.
> 
> You might need to ensure that all tests that use SharedStringsUtils have `@requires vm.cds.write.archived.java.heap`.
> 
> You should also check all other test cases to see if we misuse  `-XX:UseG1GC` for a similar reason.

Looks like all the tests that use `SharedStringsUtil` already have `@requires vm.cds.write.archived.java.heap` so they should be fine. `SharedStringsHumongous` requires G1 so I'll leave that as-is which is also consistent with the Leyden repo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1763377478