RFR: 8338883: Add core dump info to -Xlog:os=info [v6]

[Gerard Ziemski]

On Mon, 16 Sep 2024 00:55:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I find the Posix code very confusing now with unnecessary statements and checks.

Sorry David, I should have marked it as a draft, this was in-progress change, that I did not mean to be reviewed, just wanted to push it to PR, before I left for a weekend as backup.

> src/hotspot/os/posix/os_posix.cpp line 117:
> 
>> 115:       if (!check_only) {
>> 116:         // TODO: why is this true for general case?
>> 117:         will_dump_core = true;
> 
> It is already true.

WIll fix.

> src/hotspot/os/posix/os_posix.cpp line 122:
> 
>> 120:     } else if (core_path[0] == '"') { // redirect to user process
>> 121:       jio_snprintf(buffer, bufferSize, "Core dumps may be processed with %s", core_path);
>> 122:       will_dump_core = true;
> 
> It is already true.

WIll fix.

> src/hotspot/os/posix/os_posix.cpp line 130:
> 
>> 128:         if (!check_only) {
>> 129:           // TODO: why is this true for general case?
>> 130:           will_dump_core = true;
> 
> It is already true.

WIll fix.

> src/hotspot/os/posix/os_posix.cpp line 136:
> 
>> 134:           case RLIM_INFINITY:
>> 135:             jio_snprintf(buffer, bufferSize, "%s", core_path);
>> 136:             will_dump_core = true;
> 
> It is already true.

WIll fix.

> src/hotspot/os/posix/os_posix.cpp line 145:
> 
>> 143:             jio_snprintf(buffer, bufferSize, "%s (max size " UINT64_FORMAT " k). To ensure a full core dump, try \"ulimit -c unlimited\" before starting Java again", core_path, uint64_t(rlim.rlim_cur) / K);
>> 144:             if (!check_only) {
>> 145:               will_dump_core = true;
> 
> It is already true.

WIll fix.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20734#issuecomment-2356748667
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1763801341
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1763801433
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1763801534
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1763801651
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1763801825