RFR: 8298614: Support CDS heap dumping for non-G1 collectors [v2]
Leonid Mesnik
lmesnik at openjdk.org
Tue Sep 17 23:33:11 UTC 2024
On Tue, 17 Sep 2024 14:54:23 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> This patch upstreams [JDK-8333222](https://bugs.openjdk.org/browse/JDK-8333222) from the Leyden repo to support Serial and Parallel GC for CDS. Additional test fixes not in that patch were added. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>
> David and Ioi comments
Changes requested by lmesnik (Reviewer).
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsHumongous.java line 30:
> 28: * @comment -- the following implies that G1 is used (by command-line or by default)
> 29: * @requires vm.cds.write.archived.java.heap
> 30: * @requires vm.flagless
Shouldn't
@requires vm.gc.G1
works better here if only G1 is supported?
-------------
PR Review: https://git.openjdk.org/jdk/pull/21004#pullrequestreview-2311344136
PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1764209300
More information about the hotspot-runtime-dev
mailing list