RFR: 8340368: windows-x64-slowdebug build fails after JDK-8319873
Stefan Karlsson
stefank at openjdk.org
Wed Sep 18 13:37:17 UTC 2024
The build fails with:
* For target hotspot_variant-server_libjvm_objs_static_memMapPrinter_windows.obj:
memMapPrinter_windows.cpp
src\hotspot\os\windows\memMapPrinter_windows.cpp(126): error C2504: 'os::win32': base class undefined
src\hotspot\os\windows\memMapPrinter_windows.cpp(130): error C2027: use of undefined type 'os::win32'
src\hotspot\share\runtime/os.hpp(1015): note: see declaration of 'os::win32'
src\hotspot\os\windows\memMapPrinter_windows.cpp(130): error C3861: 'print_windows_version': identifier not found
src\hotspot\os\windows\memMapPrinter_windows.cpp(131): error C2027: use of undefined type 'os::win32'
src\hotspot\share\runtime/os.hpp(1015): note: see declaration of 'os::win32'
src\hotspot\os\windows\memMapPrinter_windows.cpp(131): error C3861: 'print_uptime_info': identifier not found
src\hotspot\os\windows\memMapPrinter_windows.cpp(132): error C2653: 'VM_Version': is not a class or namespace name
src\hotspot\os\windows\memMapPrinter_windows.cpp(132): error C3861: 'print_platform_virtualization_info': identifier not found
when you build without precompiled headers.
I've added the missing includes for the things listed above and ran it through our CI build system.
My intention is to push this ASAP to un-break the builds.
-------------
Commit messages:
- 8340368: windows-x64-slowdebug build fails after JDK-8319873
Changes: https://git.openjdk.org/jdk/pull/21063/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21063&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8340368
Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/21063.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21063/head:pull/21063
PR: https://git.openjdk.org/jdk/pull/21063
More information about the hotspot-runtime-dev
mailing list