RFR: 8338693: assert(Atomic::add(&ik->_shared_class_load_count, 1) == 1) failed: shared class loaded more than once [v3]

[David Holmes]

On Wed, 18 Sep 2024 17:50:21 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The test vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java  occasionally fails due to the number of shared classes being incremented even though the shared class is not loaded. This patch moves the assert to only increment once loading is possible.
>
> Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Set loading failed in non-error conditions
>  - Revert "Ioi suggestion"
>    
>    This reverts commit f60833d6bdd216c28cd7a3cbc697e8d4d318738a.

Based in Ioi's comments this seems reasonable.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20955#pullrequestreview-2314354051