RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v3]
Matthias Baesken
mbaesken at openjdk.org
Thu Sep 19 07:52:38 UTC 2024
On Tue, 17 Sep 2024 09:17:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this trivial test fix. The test fails if the `<slice>.d` directory already exists (for some reason). It needs to exist for the test to work. But if it exists we ignore the failure, thus using `Files.createDirectories()`.
>>
>> As a benefit I've also added `exclusiveAccess.dirs=.` to the `systemd` test directory to match container tests in `docker` folder and added `TRUNCATE_EXISTING` and `CREATE` open options for files in the `<slice>.d` directory. Both of which should ensure the test runs more reliably.
>>
>> Testing:
>> - [x] GHA
>> - [x] Manual testing by creating the directory first, running the test. Failed. The same handshake passes after the patch. Similarly for the user manager service not being accessible (for some reason).
>>
>> Thanks!
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into jdk-8340092-test-fix
> - Cleanup files when systemd --user fails
> - Skip test if systemd user manager not properly working
> - Add CREATE open option.
> - 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems
Marked as reviewed by mbaesken (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/20989#pullrequestreview-2314696117
More information about the hotspot-runtime-dev
mailing list