RFR: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg [v4]

[Afshin Zafari]

On Tue, 30 Jul 2024 12:25:04 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> In committing a region, it is not mandatory to provide a MEMFLAGS flag where the committed region inherits the flag from the main region it resides in.
>> In un-committing there is no need to a  MEMFLAGS at all. 
>> The `register_mapping` API of the VMATree *requires* a MEMFLAGS (via metadata arg) in both of these two operations. To do the flag inheriting, it is possible to copy the flag of the left node in the tree to the newly inserted ones. 
>> 
>> An optional bool arg (default is false) is added to VMATree API to copy the existing flag of the left node to the new nodes.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   invalid cases of register_mapping are handled.

> I'd like to suggest the following change set as the PR: [master...jdksjolen:jdk:_8335091_vmatree_copy_mtflag_on_commit](https://github.com/openjdk/jdk/compare/master...jdksjolen:jdk:_8335091_vmatree_copy_mtflag_on_commit)
> 
> It adds a set of `assert`s for when we believe that the supplied `copy_flag` argument is incorrect and has reasonable defaults.

All the changes are applied now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20330#issuecomment-2362236427