RFR: 8339192: Native annotation parsing code of deprecated annotations causes crash [v2]

David Holmes dholmes at openjdk.org
Thu Sep 19 23:47:42 UTC 2024


On Thu, 19 Sep 2024 04:57:54 GMT, John R Rose <jrose at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MIN macro was Linux specific - need MIN2
>
> Reviewed.  Nice tests.  Thanks for fixing the problem in both places.
> 
> I do think, if we have to do more of this stuff in the future, that maybe we should be writing special accessors for the CP itself, ones which can return an error indication instead of throwing an assert or crashing the VM.

Thank you for the review @rose00 and @mgronlun !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21030#issuecomment-2362384298


More information about the hotspot-runtime-dev mailing list