RFR: 8340491: Thread stack-base assertion should report which thread has the un-set stack [v2]

[Aleksey Shipilev]

On Fri, 20 Sep 2024 06:44:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This _is_ the way we do it in existing code, e.g.
>> https://github.com/openjdk/jdk/blob/46b02f49bcc730d94e37cf17fa996fdd12bdb990/src/hotspot/share/runtime/stackWatermark.hpp#L105
>
> So many ways to achieve the same thing ...
> 
> I would not want assert_stack_base in the public API.
> 
> I did need to fix the ifdef though.

`DEBUG_ONLY(;)` just triggers me, sorry. We have `NOT_DEBUG_RETURN` exactly for this reason: mark the methods that are only defined in debug builds, and shortcut otherwise :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21102#discussion_r1768074152