RFR: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver [v2]

[George Adams]

On Sat, 21 Sep 2024 05:51:28 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor to extract nanoserver detection
>
> src/hotspot/os/windows/os_windows.cpp line 4113:
> 
>> 4111: 
>> 4112:   RegCloseKey(hKey);
>> 4113:   return std::string(value, valueLength - 1); // Exclude null terminator
> 
> HotSpot code is not allowed to use anything from the C++ Standard Library, aside from very few exceptions. <string\> is unfortunately not one of those exceptions

thanks for the heads up, I've refactored this code to remove the dependency on <string> if you wouldn't mind taking another look?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21070#discussion_r1770988560