RFR: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver [v3]

[George Adams]

On Mon, 23 Sep 2024 09:51:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update os_windows.cpp
>
> src/hotspot/os/windows/os_windows.cpp line 4093:
> 
>> 4091: bool   os::win32::_job_object_processor_group_warning_displayed = false;
>> 4092: 
>> 4093: void GetWindowsInstallationType(char* buffer, int bufferSize) {
> 
> Nit: we don't use this naming style in hotspot. This should be either `getWindowsInstallationType` or `get_windows_installation_type`. Thanks

updated

> src/hotspot/os/windows/os_windows.cpp line 4119:
> 
>> 4117: }
>> 4118: 
>> 4119: bool IsNanoServer() {
> 
> Again naming style.

updated

> src/hotspot/os/windows/os_windows.cpp line 4123:
> 
>> 4121:   char installationType[BUFFER_SIZE];
>> 4122:   GetWindowsInstallationType(installationType, BUFFER_SIZE);
>> 4123:   return (lstrcmpA(installationType, "Nano Server") == 0);
> 
> Just curious do we really need `lstrcmpA` here rather than plain old `strcmp`?

strcmp is fine, I've switched it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21070#discussion_r1771115463
PR Review Comment: https://git.openjdk.org/jdk/pull/21070#discussion_r1771115622
PR Review Comment: https://git.openjdk.org/jdk/pull/21070#discussion_r1771115955