RFR: 8339460: CDS error when module is located in a directory with space in the name [v2]

[Maxim Kartashev]

On Mon, 23 Sep 2024 22:53:22 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improved the test and excluded it from hotspot_appcds_dynamic
>
> test/hotspot/jtreg/runtime/cds/appcds/complexURI/ComplexURITest.java line 46:
> 
>> 44: public class ComplexURITest {
>> 45:     final static String listFileName = "test-classlist.txt";
>> 46:     final static String archiveName  = "test-dynamic.jsa";
> 
> You're using the same `archiveName` for both static and dynamic test cases. I'd suggest declare a different archive name for the static case. E.g.
> 
> final static String staticArchiveName = "test-static.jsa";
> final static String dynamicArchiveName = "test-dynamic.jsa";
> 
> Also, I think this test should be excluded from the `hotspot_appcds_dynamic` test group in the `open/test/hotspot/jtreg/TEST.groups` file.

Done. I also added the code to safeguard against `IOException` on Windows in the case of deleting the read-only archive created previously.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20987#discussion_r1772694412