RFR: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg [v8]

[Afshin Zafari]

On Wed, 25 Sep 2024 06:54:25 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   logging/log.hpp is included
>
> src/hotspot/share/nmt/vmatree.hpp line 187:
> 
>> 185: 
>> 186:   SummaryDiff uncommit_mapping(position from, position sz, const RegionData& metadata) {
>> 187:     return register_mapping(from, from + sz, StateType::Committed, metadata, true);
> 
> As Gerard said: This should be `StateType::Reserved`, clearly this isn't caught by our tests so we do need a test that catches this.

New check is added to `NMTVMATreeTest.UseFlagInplace` gTest.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20330#discussion_r1775136960